Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext-mbstring replaced with polyfill #64

Closed
wants to merge 1 commit into from
Closed

ext-mbstring replaced with polyfill #64

wants to merge 1 commit into from

Conversation

vanodevium
Copy link

@vanodevium vanodevium commented Sep 28, 2020

Just idea. But I think it's useful

as you can see, I have some problems with pipelines. It looks like problem with gh rate limit, so it's not a problem with source code

@jawira
Copy link
Owner

jawira commented Mar 19, 2021

First of all thanks for your commit, sorry to have been slow to respond.
I like the idea of using polyfill, but I don't why you are handling MB_* constants since the polyfill is supposed to handle these.
Do you think is possible to only change "composer.json" ?

@vanodevium
Copy link
Author

@jawira Hi! Because these constants are really different in old and new versions of php.
I only unified behavior of tests with different versions.

@jawira
Copy link
Owner

jawira commented Jun 23, 2022

Hi, I really appreciate your time and effort, but I cannot merge this PR since poly-fill doesn't handle simple/full case-mapping. Also tests don't pass.
Thank you :)

@jawira jawira closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants