Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Josh Livni's Earth API library #32

Merged
merged 1 commit into from Apr 2, 2013

Conversation

dtryse
Copy link
Contributor

@dtryse dtryse commented Mar 27, 2013

Hi George,

Great library - many thanks for writing it! This is a small fix to avoid spiderfying in GE Plugin mode, if Google's Earth API library for Maps v3 is used to switch between 2D Maps and 3D Earth (while showing the same markers in both Maps/Earth).

(I'm new to github so just let me know if I did any mistakes on the fork+pull steps)

Many thanks,
David

@jawj
Copy link
Owner

jawj commented Mar 27, 2013

Thanks. One question: what happens in the Earth API with your change applied? Do markers get spiderfied nicely by Google Earth itself, as in the desktop application?

@dtryse
Copy link
Contributor Author

dtryse commented Mar 31, 2013

Hi George,

Correct - The GE Plugin will handle the spiderification natively like
desktop GE. I've attached a modified demo from the gh-pages branch (should
I do another pull.req. with this to that branch actually?).

Cheers,
David

On Wed, Mar 27, 2013 at 4:41 PM, George MacKerron
notifications@github.comwrote:

Thanks. One question: what happens in the Earth API with your change
applied? Do markers get spiderfied nicely by Google Earth itself, as in the
desktop application?


Reply to this email directly or view it on GitHubhttps://github.com//pull/32#issuecomment-15534955
.

jawj added a commit that referenced this pull request Apr 2, 2013
Compatibility with Josh Livni's Earth API library (thanks dtryse)
@jawj jawj merged commit b7ced34 into jawj:master Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants