Using Queryable for transactions?

[moltar]

Can pg.Pool be Queryable by any chance?

zapatos/src/db/transaction.ts

Line 65 in d889232

txnClientOrPool: pg.Pool | TxnClient<IsolationSatisfying<M>>,

zapatos/src/db/core.ts

Line 140 in e87524b

export type Queryable = pg.ClientBase | pg.Pool;

There's the call to release method in the finally block, which is not available on pg.Client, but maybe that can be worked around?

zapatos/src/db/transaction.ts

Line 122 in d889232

txnClient.release();

[jawj]

Hi @moltar. I'm a bit lost: from the excerpts you've shown, pg.Pool is already a member of Queryable. Can you explain what you're looking for here a bit more slowly/completely? Thanks.

[moltar]

I'd like to be able to pass pg.ClientBase instance instead of pg.Pool instance.

[tetchel]

@jawj I agree with the author here and from a short look at the code I do not see any reason this would not be possible.

Would you accept a PR with this change?

[jawj]

As of 5.0.3 it's now possible to pass a connected client instead of a pool to the transaction helper and friends (serializable, etc).