-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with NEAD format #200
Comments
Hi Baptiste, |
This format is under development by @bavay and others at SLF/WSL (can't find their GitHub handle). It's based on SMET and has been proposed to WMO as a standard. Citation for WMO proposal:
I've tried to define the format in EBNF (text and graphics) here: https://github.com/GEUS-PROMICE/NEAD but this is a work-in-progress. We plan to distribute PROMICE as NetCDF of course, but CSV is still a useful format with lower barrier to use than NetCDF. The advantage of NEAD over simple CSV or NetCDF is that you can embed most (all?) of the metadata supported by NetCDF, but hand-edit it - a requirement for the "raw" AWS data that comes in, although further down the processing chain no manual editing occurs and therefore ASCII formatted files are less useful. |
Note that if you are even considering supporting this file format, the format and required header fields are still in flux/development. |
@BaptisteVandecrux your sample data file gives a 404 file-not-found error? |
Here's a sample https://github.com/GEUS-PROMICE/NEAD/blob/main/summit.csv |
Dear JAWS team, I am adapting jaws to read NEAD files, which will be the format GC-Net data will be released in the future (see sample file above). The main issue is that (in a similar way as in the original GC-Net files) it has a variable number of fields and the field description needs to be read from the header. I have started my own branch to adapt jaws to nead: https://github.com/BaptisteVandecrux/jaws/tree/jaws_bav It uses @mankoff 's pyNEAD. I don't know how to handle that dependence in the distribution and installation of JAWS. I don't know where is the most suitable place to have this discussion: here, over a pull request, by email? Cheers |
Hello Baptiste, There are some software requirements to be aware of: |
Hi Charlie & Wenshan, My version now runs fine with default setting (converting to netcdf, filling attributes, adding sza...) and with RIGB. Is it normal that the adjusted values are full of gaps? Is that when the adjusted values are not different from the original ones or when the original ones do not make sense? I was also wondering: Thanks! |
Good job getting this far. The plots are illuminating. @wenshanw is best suited to answer your questions. |
Hi Baptiste, I will look into why there are gaps in the adjusted fsds and fsus. Without spectral info or reliable cloud observations, the current way to spot clear-sky days is just the smooth bell-shaped curves. |
I have now compared the output of RIGB when processing the NEAD file and when processing the original GC-Net text file at DYE-2 for 2015-2016. The adjusted values match pretty well apart from samples that have different un-corrected fsus and fsds in the NEAD file compared to the GC-Net file (maybe different filtering or interpolating used for the new files). I think the gaps in the adjusted values (present in both output files) are normal, we just need to know what they exactly mean. I am only missing the conda-forge compatibility of pyNEAD to make a pull request. In the meantime, Wenshan you can inspect and test the scripts that are here: I've added some sample files here: |
@BaptisteVandecrux this is a great example of community participation. When our funding for JAWS ended in 2019 we hoped that the community would continue to use, adapt, and improve it. Your work is a major step in that direction. We will do our best to help make pyNEAD a conda-forge package so we can merge your work into JAWS. Is the pyNEAD maintainer willing to joing the effort to make that a conda-forge package? |
On 2021-01-27 at 12:53 -08, Charlie Zender <notifications@github.com> wrote...
Is the pyNEAD maintainer willing to joing the effort to make that a
conda-forge package?
I'm willing to help, but I'm hesitant to claim the title of "maintainer". I've put PyNEAD under the GEUS-PROMICE project (not my own GitHub repository), and I'm not using NEAD myself anymore at the moment. But I will help as needed.
|
Thank you. Does pyNEAD have any upstream dependencies that are not already in the Conda-Forge repository? i.e., is pyNEAD a standalone tool that only requires the most common Python libraries? |
Does pyNEAD have any upstream dependencies that are not already in the
Conda-Forge repository? i.e., is pyNEAD a standalone tool that only
requires the most common Python libraries?
numpy, pandas, xarray
|
Those are all already on conda-forge, which simplifies the problem. Now we just need a pyNEAD package for conda-forge. One option is to merge pyNEAD into JAWS. The other option is to create a conda-forge pyNEAD package. Which do you prefer? |
One option is to merge pyNEAD into JAWS. The other option is to create
a conda-forge pyNEAD package. Which do you prefer?
Separate. I think pyNEAD should be accessible without requiring JAWS.
But is conda a hard requirement right now? Given that pyNEAD is young and under active development, can we install from GitHub? Some tag (e.g. 'jaws') that we move behind master but better tested than master?
Both 'requirements.txt' and conda support installing GitHub commits (tags).
|
Yes, as long as conda-forge supports it, it's fine by me. |
Hi JAWS team,
Just wanted to ask if you had tried jaws on meteoIO output?
Cheers,
Baptiste
The text was updated successfully, but these errors were encountered: