Fixes #298 #304
Merged
Fixes #298 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jax 0.4.24 they removed KeyArray from jax.random (see https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-24-feb-6-2024), the advice is now to just use jax.Array instead.
|
@sschoenholz @ekindogus I recommend approving this pull request and upping the version, because currently JAX MD cannot be pip installed with the latest version of JAX. |
|
Thanks @MarcBerneman , or indeed, yours in #299 . But in either case, this is certainly blocking anyone that just naively |
|
I would add here that some older versions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jax 0.4.24 they removed
KeyArrayfromjax.random(see https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-24-feb-6-2024), the advice is now to just usejax.Arrayinstead.One line fix. This closes #298.