[WIP] #5 #7
[WIP] #5 #7
Conversation
1 similar comment
| @@ -4,3 +4,4 @@ | |||
| "add-module-exports" | |||
| ] | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No need to this. Please refrain.
| @@ -8,7 +8,7 @@ | |||
| "test": "test" | |||
| }, | |||
| "scripts": { | |||
| "test": "xo && ava test/**/*.test.js --require babel-register", | |||
| "test": "xo && ava test/**/*.test.js --require babel-register --verbose", | |||
There was a problem hiding this comment.
If needed to do this, do in a commit only for this, explaining why.
src/container.js
Outdated
| @@ -1,45 +1,44 @@ | |||
| const debug = require('debug')('restinga:container'); | |||
There was a problem hiding this comment.
This whole file diff is wrong. Editing the container isn't intended. We need to remove it.
src/descriptor.js
Outdated
| } | ||
| } | ||
| module.exports = function ({service, prefix, agent}) { | ||
| this.service = service; |
There was a problem hiding this comment.
Don't do this in a function.
Prefer to return a object.
| @@ -1,5 +1,5 @@ | |||
| import Request from './request'; | |||
| import {Container} from './'; | |||
| // import descriptor from './descriptor'; | |||
There was a problem hiding this comment.
ok, i had already removed the comments on the last commit.
src/resource.js
Outdated
| @@ -25,7 +25,8 @@ export default class Resource { | |||
| this.collectionRoot = collectionRoot; | |||
| this.itemRoot = itemRoot; | |||
|
|
|||
| this.descriptor = Container.get(this.service); | |||
| const obj = {service: 'json-placeholder', prefix: 'http://jsonplaceholder.typicode.com', agent: 'restinga-node/1.0.0 (https://github.com/jay-ess/restinga-node)'}; | |||
There was a problem hiding this comment.
Name it const descriptor to be more clear.
Don't make it a one-liner as it's too big.
src/resource.js
Outdated
| @@ -25,7 +25,8 @@ export default class Resource { | |||
| this.collectionRoot = collectionRoot; | |||
| this.itemRoot = itemRoot; | |||
|
|
|||
| this.descriptor = Container.get(this.service); | |||
| const obj = {service: 'json-placeholder', prefix: 'http://jsonplaceholder.typicode.com', agent: 'restinga-node/1.0.0 (https://github.com/jay-ess/restinga-node)'}; | |||
| this.descriptor = obj || null; | |||
There was a problem hiding this comment.
You're not receiving a descriptor from the user, you're mocking one!
test/resource.test.js
Outdated
| @@ -1,10 +1,10 @@ | |||
| import test from 'ava'; | |||
| import {Container} from '../src'; | |||
| // import {Container} from '../src'; | |||
test/resource.test.js
Outdated
| import {JsonPlaceholderService, PostResource, CommentResource} from './fixtures'; | ||
|
|
||
| const jsonPlaceholderService = new JsonPlaceholderService(); | ||
|
|
||
| Container.register(jsonPlaceholderService); | ||
| // Container.register(jsonPlaceholderService); |
|
Don't forget I asked for the commits deletion. |
1 similar comment
No description provided.