Skip to content

Commit

Permalink
bill found a fix for the notebook failing inside kubernetes that was …
Browse files Browse the repository at this point in the history
…the 0.0.0.0 ip address on notebook start
  • Loading branch information
jay-johnson committed Dec 7, 2018
1 parent 9f726ad commit 6d179f8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 10 additions & 2 deletions docker/jupyter/start-container.sh
Expand Up @@ -86,11 +86,19 @@ if [[ "${NOTEBOOK_DIR}" != "" ]]; then
fi
fi

# 5.6.0 of notebook pip fails with --ip=*
# now supports changing to debug without
# logging into the container using an env var
default_ip="0.0.0.0"
if [[ "${JUPYTER_CUSTOM_IP}" != "" ]]; then
default_ip="${JUPYTER_CUSTOM_IP}"
fi

echo ""
echo "Starting Jupyter with command: "
echo "jupyter notebook --ip=* --port=8888 --no-browser --config=${notebook_config} --notebook-dir=${notebook_dir} --allow-root"
echo "jupyter notebook --ip=${default_ip} --port=8888 --no-browser --config=${notebook_config} --notebook-dir=${notebook_dir} --allow-root"
jupyter notebook \
--ip=* \
--ip=${default_ip} \
--port=8888 \
--no-browser \
--config=${notebook_config} \
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -94,7 +94,7 @@ def run_tests(self):
setup(
name="antinex-core",
cmdclass={"test": PyTest},
version="1.3.12",
version="1.3.13",
description=(
"AntiNex publisher-subscriber core for processing "
"training and prediction requests for deep neural "
Expand Down

0 comments on commit 6d179f8

Please sign in to comment.