Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueCellRevealer propagating already revealed cells in OnCellsUpdated event #12

Closed
jayasuryat opened this issue Nov 27, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jayasuryat
Copy link
Owner

jayasuryat commented Nov 27, 2021

ValueCellRevealer propagating already revealed cells in OnCellsUpdated event.

(See) for RevealedCell

(See) for FlaggedCell

Altho this will not affect UI as MutableStatefulGrid is using structuralEqualityPolicy() to generate the MutableState, so, based on diffs there might not be any recompositions triggered for these particular cells.

But, any custom logic present at any of the StatefulGrid implementation in the updateCellsWith method's onEach block will get triggered unnecessarily.

So, anyways as these cells don't need to be part of the event, at these particular branches we can just return emptyList()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant