Set response on the context #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e identical behavior as appollo-link
jaydenseric
requested changes
Nov 17, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "apollo-upload-client", | |||
| "version": "6.0.2", | |||
| "version": "6.0.3", | |||
There was a problem hiding this comment.
Best to undo this; I'll update the changelog and version in a few places myself prior to a release.
jaydenseric
approved these changes
Nov 19, 2017
jaydenseric
requested changes
Nov 19, 2017
src/index.mjs
Outdated
| @@ -66,6 +74,7 @@ export const createUploadLink = ( | |||
| .then(response => { | |||
| if (!response.ok) | |||
| throw new Error(`${response.status} (${response.statusText})`) | |||
| operation.setContext({ response }) | |||
There was a problem hiding this comment.
This should come before the response check above. Otherwise if the response is not ok, the response will not be attached to the context like in apollo-link-http.
jaydenseric
approved these changes
Nov 19, 2017
jaydenseric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In apollo-link the raw-response is available in the context in order to e.g. access the response headers in a afterware.
Ive attached the response here too.
https://github.com/apollographql/apollo-link/blob/685b07dd024b2e97a0929ac841ba5e1d19aa042a/packages/apollo-link-http/src/httpLink.ts#L179