Possible false positive bug with destructured named exports

[dburles]

Reproduction: https://github.com/dburles/find-unused-exports-issue

I found that exporting named exports in this way results in a false positive with no exports named:

index.js
  
1 unused export in 1 module.

[jaydenseric]

Interesting, maybe you could take a stab at a PR?

[jaydenseric]

Probably a destructured variable export hasn't been accounted for near here:

find-unused-exports/private/scanModuleCode.js

Lines 111 to 118 in 3208426

	case 'VariableDeclaration':
	// E.g. `export const a = true`
	// ^^^^^^^^^^^^^^
	// E.g. `export var a, b, c = true`
	// ^^^^^^^^^^^^^^^^^^
	path.node.declaration.declarations.forEach(({ id: { name } }) => {
	analysis.exports.add(name);
	});

[jaydenseric]

Also, what about array destructuring? E.g. something like:

export const [a] = [true];

[jaydenseric]

Also, need to account for this:

export const { a, b: c } = { a: true, b: true };

[jaydenseric]

What about this:

export const [, a] = [true, true];

Edit: So I tested the above in Node.js, using:

import * as a from './a.mjs';

console.log(a);

And the result was [Module] { a: true }, so it does seem to be valid and we need to account for it.

[jaydenseric]

Holy cow! Just released this needs to be a recursive operation as the destructuring can be arbitrarily deep/complex:

export const { k, l: { m: [n]} } = { k: true, l: { m: [true] } };

In that case the named exports are k and n.

[jaydenseric]

Also, spread syntax:

export const { a, ...b } = { a: true, b: true, c: true };
export const [, ...c] = [1, 2];

[jaydenseric]

The fix has been published in v1.1.1 🚀