[v14.0.0] No "main" export in package.json causes import failures

[stewartmcgown]

Package.json does not export a barrel file index, so all existing code must be update to support imports from each unique file inside the package

[jaydenseric]

This is by design, and is documented in the v14 changelog entry under major changes. Deep importing modules with a single export as needed is a vastly more efficient pattern than redundantly loading every module in the package by importing via an index module, just to use one or two of the exports and ignore the rest. This pattern is critical to efficiency in browsers, but also Deno, and even Node.js sees benefits. Projects that bundle will be able to do so with perfect efficiency without needing to do any sort of ESM "tree shaking".

I have been dropping the package main index module anti-pattern from all of my packages; graphql-upload was one of the last ones remaining.

[SueHeir]

Sorry I'm a novice here, what does this mean in terms of fixing the error?

[PiTiLeZarD]

use

import GraphQLUpload from "graphql-upload/GraphQLUpload.js";

instead of the traditional

import { GraphQLUpload } from "graphql-upload";

[jaydenseric]

@SueHeir the module structure has changed in graphql-upload v14, and you need to update the way you import the modules.

You can't import them like this anymore:

import { graphqlUploadExpress } from "graphql-upload";

You need to deep import them like this instead:

import graphqlUploadExpress from "graphql-upload/graphqlUploadExpress.js";

You can see all the available publicly exported modules you can import this way documented here:

https://github.com/jaydenseric/graphql-upload/tree/v14.0.0#exports

If you get confused, you can always just look at the contents of the node_modules/graphql-upload/ directory to see what modules there are:

https://unpkg.com/browse/graphql-upload@14.0.0/

[jaydenseric]

Note that when this package updates to pure ESM in a major release coming hopefully within the next few months, the module structure will be the same as v14 except the file extensions will change to .mjs from .js. So we will need to update our imports in projects a second time 😅 It's a pretty easy find and replace tho.

[SueHeir]

Thank you!!

[strangeweb3guy]

@SueHeir the module structure has changed in graphql-upload v14, and you need to update the way you import the modules.

You can't import them like this anymore:

import { graphqlUploadExpress } from "graphql-upload";

You need to deep import them like this instead:

import graphqlUploadExpress from "graphql-upload/graphqlUploadExpress.js";

You can see all the available publicly exported modules you can import this way documented here:

https://github.com/jaydenseric/graphql-upload/tree/v14.0.0#exports

If you get confused, you can always just look at the contents of the node_modules/graphql-upload/ directory to see what modules there are:

https://unpkg.com/browse/graphql-upload@14.0.0/

import graphqlUploadExpress from "graphql-upload/graphqlUploadExpress.js";

[jaydenseric]

@kiskesis you might have some sort of build step that is adding .default to your default import values. This is not the right thing to do; you will get this error for a lot of npm package you import from.

[strangeweb3guy]

Hmm, I have a really big count of modules and don't have this error for them.

[strangeweb3guy]

So any ideas on how I can fix that?

[jaydenseric]

@kiskesis within your project, create a demo.mjs file, and in there:

import graphqlUploadExpress from "graphql-upload/graphqlUploadExpress.js";

console.log(graphqlUploadExpress);

Then in terminal within the project directory run node demo.mjs and see that it logs the function just fine. I can't really help you with a faulty build setup; there are a million things that could be misconfigured in your tooling.