Fix and test for invalid operations and map field types
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MickVanDuijn
changed the title
jaydenseric
reviewed
Apr 4, 2019
src/processRequest.mjs
Outdated
| @@ -193,6 +197,14 @@ export const processRequest = ( | |||
| createError(413, `${maxFiles} max file uploads exceeded.`) | |||
| ) | |||
|
|
|||
| if (typeof operations !== 'object') | |||
There was a problem hiding this comment.
I'm not sure this check is necessary, because operations has already been checked at this point?
Still need to handle an invalid ‘map’ type.
|
Thanks for bringing this up! I've handled a few issues (e.g. I'll take it from here, as the |
`null` is more likely to reveal issues as it is technically an object.
jaydenseric
changed the title
operations and map field types.
jaydenseric
changed the title
operations and map field types.operations and map field types
|
Thanks! This at least solved one of the problems I had, but null is another tricky one indeed! What would be the ETA for this to be in a new release? |
|
@MickVanDuijn I plan to release today. |
jaydenseric
approved these changes
Apr 5, 2019
|
Thanks 🙌 |
|
Published in v8.0.5 🚀 |
|
🚀 Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
operationsis of typestring, andoperationsPath.setis called, the error was not correctly propagated.