Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added italian 🇮🇹 language #185 #397

Merged

Conversation

peppermint-juli
Copy link

✅ New Language Checklist

  • ✅ There is ❌ no assigned issue or pull request for this new language.
  • ✅ ➕ Added a new JSON object in the server/data/languages.json file.
  • ✅ Added the voice 🎤 attribute supported by ResponsiveVoice API.
  • ✅ Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
  • ✅ Added the romanization attribute for appropriate languages. (There was no need for this, since this is a roman language)
  • ✅ ➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
  • ✅ Removed duplicates and noted 🗒 them in the Pull Request.
  • ✅ Increment currentLanguagesCount in client/src/store/index.js
  • ✅ Add new language in README.md

Copy link
Owner

@jayehernandez jayehernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Letra ☀️, @PeppermintNDaisies!! Appreciate your contribution to this open source project. 🥳

I'll be including this in the next release.


Continue supporting Letra by:

@jayehernandez jayehernandez merged commit 1afdd3e into jayehernandez:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants