New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added urdu words #512

Closed

shehriyarnadeem wants to merge 5 commits into jayehernandez:master from shehriyarnadeem:Adding-urdu-language

shehriyarnadeem commented Oct 30, 2020 •

edited

#98 ✅ New Quote Checklist

The quote(s) added are in alphabetical order by author's first name and not ❌ duplicates.
The quote(s) added are about learning a foreign language.
The sentence attribute does not have inner quotation marks, and is ended with a period.
Copy pasted the raw JSON quotes.json file to JSONLint and made sure that the modified JSON file is valid.

✅ New Language Checklist

There is ❌ no assigned issue or pull request for this new language.
[X ] ➕ Added a new JSON object in the server/data/languages.json file.
Added the voice 🎤 attribute supported by ResponsiveVoice API.
[X ] Added the flag 🏳 attribute in the format of the twemoji-awesome CSS syntax.
Added the romanization attribute for appropriate languages.
➕ Created the {language.json} file inside the server/data/words folder containing the list of the 3000 words.
[X ] Removed duplicates and noted 🗒 them in the Pull Request.
Increment currentLanguagesCount in client/src/store/index.js
[X ] Add new language in README.md

shehriyarnadeem and others added 3 commits

October 30, 2020 16:03


          Added urdu language

9cfa373


          Merge branch 'master' into Adding-urdu-language

8c7c18e


          Fix lint Issue

e920772

shehriyarnadeem changed the title ~~Added urdu language~~ Added urdu words all 3000

shehriyarnadeem changed the title ~~Added urdu words all 3000~~ Added urdu words

shehriyarnadeem added 2 commits

October 30, 2020 16:13


          Merge branch 'Adding-urdu-language' of https://github.com/shehriyarna…

bd9efab

…deem/letra-extension into Adding-urdu-language


          Fixed lint error

c084d6f

Kvaibhav01 suggested changes

View reviewed changes

Contributor

Kvaibhav01 left a comment

Please follow the new language contribution guidelines before making a PR or working on it. The Urdu language isn't supported by the Responsive Voice API.

There's no language called "Pakistan". Also, you need to first comment on the issue first.

Please close this PR.

Author

shehriyarnadeem commented Oct 30, 2020

Understood. Closing PR.

shehriyarnadeem closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment