Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to follow configuration's quality settings #14

Closed
mattreecebentley opened this issue Oct 17, 2019 · 2 comments
Closed

Fails to follow configuration's quality settings #14

mattreecebentley opened this issue Oct 17, 2019 · 2 comments
Assignees
@jaylinski
Labels
bug Something isn't working
Milestone
v5.1.0

Comments

@mattreecebentley
Copy link

mattreecebentley commented Oct 17, 2019 •
edited

When settings are set to 720p, addon will still play at whatever the highest resolution the video is available in.
Even if the inputstream addon is also set to 720p, vimeo addon will still play at 4k if video is available at 4k.
@jaylinski jaylinski self-assigned this Oct 17, 2019
@jaylinski jaylinski added the bug Something isn't working label Oct 17, 2019
@jaylinski
Copy link
Owner

@mattreecebentley This is only true for videos with AV1 format and a temporary workaround: https://github.com/jaylinski/kodi-addon-vimeo/blob/v5.0.1/resources/lib/vimeo/api.py#L173

The problem: for some videos (mostly staff pics) Vimeo only returns video-URLs encoded in AV1 format. Since Kodi can't play AV1 yet, the workaround is to use the HLS stream (since it contains mpeg encoded streams).

More detailed post about AV1: https://forum.kodi.tv/showthread.php?tid=220437&pid=2879012#pid2879012

Thread on Kodi AV1 support is here: https://forum.kodi.tv/showthread.php?tid=346272

I could try and filter out non-matching resolutions in the HLS master playlist to make this work. 🤔

@jaylinski jaylinski added this to the v5.1.0 milestone Oct 18, 2019
jaylinski added a commit that referenced this issue Feb 24, 2020
@jaylinski
Use more powerful Vimeo client ID
ac10b35 
This greatly improves the video-start-time performance.
HLS playlists also seem to be in AVC format, thus not
requiring to remove AV1 items from the playlist.

Videos that couldn't be played before because of restrictive
embedding settings can now be played.

Other notable changes:
* Use new AVC HLS stream from player API
* Added action to clear the cache in settings
* Added AV1 codec switch
* Added 4k resolution to settings
* Added search template

Fixes #7 #14 #18 and resolves #4
@jaylinski jaylinski mentioned this issue Feb 24, 2020
Merged
2 tasks
@jaylinski
Copy link
Owner

jaylinski commented Feb 25, 2020 •
edited

This should be resolved in version 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaylinski jaylinski

Labels
bug Something isn't working
Projects
None yet
Milestone
v5.1.0
Development

No branches or pull requests
2 participants
@jaylinski @mattreecebentley