Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SSH for the forked remote, even if the non-forked one is https #56

Closed
jaymzh opened this issue Oct 21, 2020 · 0 comments · Fixed by #57
Closed

Use SSH for the forked remote, even if the non-forked one is https #56

jaymzh opened this issue Oct 21, 2020 · 0 comments · Fixed by #57
Assignees
@jaymzh

Comments

@jaymzh
Copy link
Owner

jaymzh commented Oct 21, 2020

people sclone on https://github.com/foo/bar or just foo/bar which defaults to https. This makes sense as they likely don't have write access to it. We fork that, and then also use https, but we should use ssh for that since they DO have access to that.
@jaymzh jaymzh self-assigned this Oct 21, 2020
jaymzh added a commit that referenced this issue Nov 21, 2020
@jaymzh
Always use SSH for forked remote; handle various repo paths better
1a4212c 
A user who clones-and-forks an https repo they don't have commit
access to, still wants their forked repo to be using SSH so they
can push to it and make PRs.

In addition, we were misparsing repo paths in a variety of different
ways, so this centralizes that parsing into two methods, uses them
consistently, and then unittests them in a variety of cases.

This closes #56
@jaymzh jaymzh mentioned this issue Nov 21, 2020
Merged
jaymzh added a commit that referenced this issue Nov 21, 2020
@jaymzh
Always use SSH for forked remote; handle various repo paths better
4984185 
A user who clones-and-forks an https repo they don't have commit
access to, still wants their forked repo to be using SSH so they
can push to it and make PRs.

In addition, we were misparsing repo paths in a variety of different
ways, so this centralizes that parsing into two methods, uses them
consistently, and then unittests them in a variety of cases.

This closes #56

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit that referenced this issue Nov 21, 2020
@jaymzh
Always use SSH for forked remote; handle various repo paths better
295a2a7 
A user who clones-and-forks an https repo they don't have commit
access to, still wants their forked repo to be using SSH so they
can push to it and make PRs.

In addition, we were misparsing repo paths in a variety of different
ways, so this centralizes that parsing into two methods, uses them
consistently, and then unittests them in a variety of cases.

This closes #56

Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh added a commit that referenced this issue Nov 21, 2020
@jaymzh
Always use SSH for forked remote; handle various repo paths better (#57)
6f5d4a1 
A user who clones-and-forks an https repo they don't have commit
access to, still wants their forked repo to be using SSH so they
can push to it and make PRs.

In addition, we were misparsing repo paths in a variety of different
ways, so this centralizes that parsing into two methods, uses them
consistently, and then unittests them in a variety of cases.

This closes #56

Signed-off-by: Phil Dibowitz <phil@ipom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaymzh jaymzh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always use SSH for forked remote; handle various repo paths better jaymzh/sugarjar
1 participant
@jaymzh