Get NIC Speed and Duplex from SysFs if ethtool is not available.

Update ParseBool to return `false` for empty strings.

Signed-off-by: Jacob Young <jacoby@nvidia.com>

pkg/net/net_linux.go

@@ -71,6 +71,8 @@ func nics(ctx *context.Context) []*NIC {
 			nic.netDeviceParseEthtool(ctx, filename)
 		} else {
 			nic.Capabilities = []*NICCapability{}
+			// Sets NIC struct fields from data in SysFs
+			nic.setNicAttrSysFs(paths, filename)
 		}
 
 		nic.PCIAddress = netDevicePCIAddress(paths.SysClassNet, filename)
@@ -248,6 +250,38 @@ func netDevicePCIAddress(netDevDir, netDevName string) *string {
 	return &pciAddr
 }
 
+func (nic *NIC) setNicAttrSysFs(paths *linuxpath.Paths, dev string) {
+	// Get speed and duplex from /sys/class/net/$DEVICE/ directory
+	nic.Speed = readFile(filepath.Join(paths.SysClassNet, dev, "speed"))
+	nic.Duplex = readFile(filepath.Join(paths.SysClassNet, dev, "duplex"))
+}
+
+func readFile(path string) string {
+	contents, err := ioutil.ReadFile(path)
+	if err != nil {
+		return ""
+	}
+	return strings.TrimSpace(string(contents))
+}
+
+func (nic *NIC) setNicAttrEthtool(ctx *context.Context, dev string) error {
+	path, _ := exec.LookPath("ethtool")
+	cmd := exec.Command(path, dev)
+	var out bytes.Buffer
+	cmd.Stdout = &out
+	err := cmd.Run()
+	if err != nil {
+		msg := fmt.Sprintf("could not grab NIC link info for %s: %s", dev, err)
+		ctx.Warn(msg)
+		return err
+	}
+
+	m := parseNicAttrEthtool(&out)
+	nic.updateNicAttrEthtool(m)
+
+	return nil
+}
+
 func autoNegCap(m map[string][]string) *NICCapability {
 	autoNegotiation := NICCapability{Name: "auto-negotiation", IsEnabled: false, CanEnable: false}
 

pkg/util/util.go

@@ -71,6 +71,9 @@ func ParseBool(str string) (bool, error) {
 			"off": false,
 			"yes": true,
 			"no":  false,
+			// Return false instead of an error on empty strings
+			// For example from empty files in SysClassNet/Device
+			"": false,
 		}
 		if b, ok := ExtraBools[strings.ToLower(str)]; ok {
 			return b, nil

pkg/util/util_test.go

@@ -75,6 +75,10 @@ func TestParseBool(t *testing.T) {
 			item:     "1",
 			expected: true,
 		},
+		{
+			item:     "",
+			expected: false,
+		},
 		{
 			item:     "on",
 			expected: true,