ARM: failed to determine memory area for node: open /sys/devices/system/memory/block_size_bytes: no such file or directory

[wanyaoqi]

topology.New() will report:
WARNING: failed to determine memory area for node: open /sys/devices/system/memory/block_size_bytes: no such file or directory

ARM no /sys/devices/system/memory directory.
As the this comment: kata-containers/runtime#796 (comment)
ARM not support memory hotplug，and i can't get physical memory from sysfs.

Is there any way around this problem

[jaypipes]

Hi @wanyaoqi thanks for submitting this issue. You can turn off these warnings. For ARM, topology memory information may not be available due to platform limitations.

[wanyaoqi]

Hi @jaypipes , thanks for your reply. The problem is get numa node physical memory size, others topo info is works.
And i don't need numa node physical memory size actually, so i just paste usable size to physical size to workaround this problem. wanyaoqi#1
Can we check /sys/devices/system/memory/block_size_bytes file exists, if not exist return a inaccuracy value( usable size) or return -1 rather than return a error, because other numa topo infomation is work.

[jaypipes]

Hi @jaypipes , thanks for your reply. The problem is get numa node physical memory size, others topo info is works. And i don't need numa node physical memory size actually, so i just paste usable size to physical size to workaround this problem. wanyaoqi#1 Can we check /sys/devices/system/memory/block_size_bytes file exists, if not exist return a inaccuracy value( usable size) or return -1 rather than return a error, because other numa topo infomation is work.

@wanyaoqi we already do that :)

ghw/pkg/memory/memory_linux.go

Lines 113 to 119 in 227643e

	// detect physical memory from /sys/devices/system/memory
	dir := paths.SysDevicesSystemMemory
	blockSizeBytes, err := memoryBlockSizeBytes(dir)
	if err != nil {
	total = -1
	return total
	}

[wanyaoqi]

Hi @jaypipes , thanks for your reply. The problem is get numa node physical memory size, others topo info is works. And i don't need numa node physical memory size actually, so i just paste usable size to physical size to workaround this problem. wanyaoqi#1 Can we check /sys/devices/system/memory/block_size_bytes file exists, if not exist return a inaccuracy value( usable size) or return -1 rather than return a error, because other numa topo infomation is work.

@wanyaoqi we already do that :)

ghw/pkg/memory/memory_linux.go

Lines 113 to 119 in 227643e

	// detect physical memory from /sys/devices/system/memory
	dir := paths.SysDevicesSystemMemory
	blockSizeBytes, err := memoryBlockSizeBytes(dir)
	if err != nil {
	total = -1
	return total
	}

@jaypipes Okay, but function AreaForNode seems like not fixed ？

ghw/pkg/memory/memory_linux.go

Lines 60 to 71 in 227643e

	func AreaForNode(ctx *context.Context, nodeID int) (*Area, error) {
	paths := linuxpath.New(ctx)
	path := filepath.Join(
	paths.SysDevicesSystemNode,
	fmt.Sprintf("node%d", nodeID),
	)
	blockSizeBytes, err := memoryBlockSizeBytes(paths.SysDevicesSystemMemory)
	if err != nil {
	return nil, err
	}

[wanyaoqi]

AreaForNode should call memTotalPhysicalBytes like this:

func AreaForNode(ctx *context.Context, nodeID int) (*Area, error) {
	paths := linuxpath.New(ctx)
	path := filepath.Join(
		paths.SysDevicesSystemNode,
		fmt.Sprintf("node%d", nodeID),
	)

	totPhys := memTotalPhysicalBytes(paths)
	totUsable, err := memoryTotalUsableBytesFromPath(filepath.Join(path, "meminfo"))
	if err != nil {
		return nil, err
	}

	supportedHP, err := memorySupportedPageSizes(filepath.Join(path, "hugepages"))
	if err != nil {
		return nil, err
	}

	return &Area{
		TotalPhysicalBytes: totPhys,
		TotalUsableBytes:   totUsable,
		SupportedPageSizes: supportedHP,
	}, nil
}

[jaypipes]

@wanyaoqi gotcha. I will push a fix shortly. :) thank you!

[mogren]

I guess this issue can be closed? 😄