toolchain update #290
Merged
toolchain update #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we fixed jaypipes#275 (allow marshal/unmarshal cycle for block.Info), we discovered few more occourrences which also prevented full JSON encode/decode/encode cycles (aka roundtrips). All of the new findings still see unnecessary limitations, so this patch adds the missing functions. Fixes: jaypipes#283 Signed-off-by: Francesco Romani <fromani@redhat.com>
Let's begin the toolchain rotation by removing golang 1.14 from the supported set. It's just too old nowadays (november 2021). Signed-off-by: Francesco Romani <fromani@redhat.com>
The minimum version of golang we recommend and test in CI is 1.15 anyway. Signed-off-by: Francesco Romani <fromani@redhat.com>
This PR implements the changes automatically done using ``` gofmt -s -w . ``` Signed-off-by: Francesco Romani <fromani@redhat.com>
Signed-off-by: Francesco Romani <fromani@redhat.com>
Remove generic test that needs to be moved in the os-specific test until the tier-2 platform (mac, win) catch up with the implementation. These tests are meant to be in the linux-specific test from the beginning, they seem to have sneaked in the generic codebase due to a rebase glitch. Signed-off-by: Francesco Romani <fromani@redhat.com>
Add golang 1.17 to our supported matrix. Signed-off-by: Francesco Romani <fromani@redhat.com>
We used golang 1.15 on mac only because it was the latest version available. Signed-off-by: Francesco Romani <fromani@redhat.com>
jaypipes
approved these changes
Nov 23, 2021
| @@ -4,6 +4,7 @@ | |||
| // See the COPYING file in the root project directory for full text. | |||
| // | |||
|
|
|||
| //go:build linux | |||
| // +build linux | |||
There was a problem hiding this comment.
in a future PR, we should move this to the top of the file, to be consistent with all the other files. Same with other _test.go fles...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotate the supported golang versions: golang 1.14, add golang 1.17. Includes fix to keep CI green.
Fixes: #289