Rework cobra CLI #41
Merged
Rework cobra CLI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved the CLI into cmd package.
* Broke out each subcommand into own file.
* Created a version subcommand, which allows the binary to be built
with version information when passed the following LDFLAGS.
LDFLAGS := -s -w \
-X 'main.version=$(VERSION)'
-X 'main.buildHash=$(GITCOMMIT)'
-X 'main.buildDate=$(BUILDDATE)'
|
Also added a sexy command banner lol |
Since the CLI imports gcw the vendor/ directory should live at the base of the repo. This also brings the project in line with most other go projects. Updated Makefile and gitignore to preserve functionality.
retr0h
force-pushed
the
rework-cobra-cli
branch
from
4bda0ed
to
5d68bd0
Compare
jaypipes
requested changes
Aug 9, 2018
cmd/root.go
Outdated
| .-----. | |--. .--.--.--. | ||
| | _ | | | | | | | | ||
| |___ | |__|__| |________| | ||
| |_____| |
There was a problem hiding this comment.
lol, this makes me think of someone giving someone else the middle finger.
cmd/version.go
Outdated
| ` | ||
|
|
||
| // versionCmd represents the version command | ||
| var versionCmd = &cobra.Command{ |
There was a problem hiding this comment.
Cool. I'd wanted to do something like this. Thanks for adding it! :)
vendor/vendor.json
Outdated
| @@ -21,5 +21,5 @@ | |||
| "revisionTime": "2017-05-08T18:43:26Z" | |||
| } | |||
| ], | |||
| "rootPath": "github.com/jaypipes/ghw/ghwc" | |||
| "rootPath": "github.com/jaypipes/ghw" | |||
There was a problem hiding this comment.
So, the reason I had the ghwc/vendor folder was that I did not want to make cobra a dependency for the ghw library itself. I wanted to have as few (or no) dependencies for the importable library as possible. Is there a way to indicate that the dependency is only for the ghwc example client tool and not the library itself?
There was a problem hiding this comment.
Ah, I seee. Now I understand what ghwc was for.
This reverts commit 5d68bd0.
This should allow the CLI to remain using vendored packages, while keeping dependencies as minimal as possible with the importable package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the CLI into cmd package.
Broke out each subcommand into own file.
Created a version subcommand, which allows the binary to be built
with version information when passed the following LDFLAGS.
LDFLAGS := -s -w
-X 'main.version=$(VERSION)'
-X 'main.buildHash=$(GITCOMMIT)'
-X 'main.buildDate=$(BUILDDATE)'