Add support for ghw_chroot #11
Conversation
There was a problem hiding this comment.
OK, @chiptus thanks so much for your PR! Please go ahead and make the change to the env var I've requested inline.
Also, if you wouldn't mind editing the README.md file to mention how to use the PCIDB_CHROOT env var, that would be great. Feel free to use similar text as what is in the ghw README. Something like this would be good:
NOTE: The default root mountpoint that pcidb uses when looking for information about the host system is /. So, for example, when looking up CPU information on Linux, pcidb will attempt to discover a pciids DB file at /usr/share/misc/pci.ids. If you are calling pcidb from a system that has an alternate root mountpoint, you can set the PCIDB_CHROOT environment variable to that alternate path. for example, if you are executing from within an application container that has bind-mounted the root host filesystem to the mount point /host, you would set PCIDB_CHROOT to /host so that pcidb can find files like /usr/share/misc/pci.ids at /host/usr/share/misc/pci.ids.
|
I'll go ahead and add the README bits. Thanks, @chiptus! 👍 |
|
sorry, forgot about that. Almost night here :D
…On Thu, Nov 8, 2018 at 6:50 PM Jay Pipes ***@***.***> wrote:
I'll go ahead and add the README bits. Thanks, @chiptus
<https://github.com/chiptus>! 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUVF6tC8zhFCmUUcVQN4H_lz7S13BDvks5utGDEgaJpZM4YUZmy>
.
|
closes #10
This PR gets the value of GHW_CHROOT as the host root to look for pci info.
It also fixes a bug where search paths weren't added to slice (pass reference instead of value)