remove PCI prefix and Id fields #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THIS IS A BACKWARDS-INCOMPATIBLE CHANGE Due to the fact that pcidb used to be a submodule in the ghw library, all of its publicly-exposed structs used to be prefixed with "PCI". Now that pcidb is its own library, there's no reason to continue using that prefix. Since this is a backwards-incompatible change, I took the opportunity to remove the old "Id" fields which had been deprecated in the 0.2 release. No use waiting around to remove those for a 1.0 release when this change is backwards incompatible anyway. Issue #9
Changes the name of the internal options struct to "context" since that is more appropriate for what it is. Refactors the determination of search paths into a method on the context struct and places that functionality into a new context.go file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BACKWARDS-INCOMPATIBLE CHANGE
Due to the fact that pcidb used to be a submodule in the ghw library,
all of its publicly-exposed structs used to be prefixed with "PCI". Now
that pcidb is its own library, there's no reason to continue using that
prefix.
Since this is a backwards-incompatible change, I took the opportunity to
remove the old "Id" fields which had been deprecated in the 0.2 release.
No use waiting around to remove those for a 1.0 release when this change
is backwards incompatible anyway.
Issue #9