Add option for direct path to pci.ids #24
Conversation
|
This accommodates systems like OpenXT that store the PCI database in unconventional locations, or development systems that wish to use the database of a target system without reconfiguring the host environment. |
There was a problem hiding this comment.
Little naming suggestion, otherwise this is awesome, thank you @pearsonk!
In prep for the v0.6.0 release, once this is merged I'll update the README docs to explain the various options that allow discovering/overriding the PCIIDS file.
context.go
Outdated
| @@ -25,6 +26,7 @@ func contextFromOptions(merged *WithOption) *context { | |||
| cacheOnly: *merged.CacheOnly, | |||
| cachePath: getCachePath(), | |||
| disableNetworkFetch: *merged.DisableNetworkFetch, | |||
| directPath: *merged.DirectPath, | |||
There was a problem hiding this comment.
How about we call this just Path instead of DirectPath? since it's an option, if Path is set, it overrides any of the auto-discovery features.
|
Had an oops with a git rebase, will resubmit soon |
For systems placing the pci.ids database in a location other than <chroot>/usr/share/misc/pci.ids Signed-off-by: Kevin Pearson <kevin.pearson@ortmanconsulting.com>
|
Simplified DirectPath to Path, changed behavior to not enumerate cache or conventional locations when Path is set. |
For systems placing the pci.ids database in a location other than
/usr/share/misc/pci.ids
Signed-off-by: Kevin Pearson kevin.pearson@ortmanconsulting.com