Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in Progress: python 3 compatability #5

Merged
merged 4 commits into from
Mar 9, 2015

Conversation

kristianperkins
Copy link
Collaborator

This pull request is a work in progress for python 3 compatibility. The main changes are:

  • all strings are now unicode strings
  • dependency on the future module to backport some python 3 namespace changes to python 2 (and add things like basestring to python 3)
  • the use of futures install_aliases() makes flake8 unhappy

@kristianperkins
Copy link
Collaborator Author

Currently, python 2 still works, python 3 has minimal functionality (metadata commands don't work, pagination of selects doesn't work after the initial read) and tests fail in python 3.

Edit: Tests fail in python 3 because None is not orderable, so min and max don't work with None in them 😦

@jaysw
Copy link
Owner

jaysw commented Mar 9, 2015

Wow, many thanks KP! I'll see if I can help with the rest! 🍻

jaysw added a commit that referenced this pull request Mar 9, 2015
Work in Progress: python 3 compatability
@jaysw jaysw merged commit fff57ab into jaysw:master Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants