Fix so that builds won't pass when integration tests fail #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the old behaviour as of 2.9.0-beta-5 but a regression entered with ecccb4a, when the mojo was upgraded to use ddmlib instead of the adb command. The com.android.ddmlib.testrunner.RemoteAndroidTestRunner.run() doesn't throw an exception when tests fail, instead it relies on the test listeners to report failures/errors to the user - so I've updated the AndroidTestRunListener to do just that, throwing a MojoFailureException and also reporting the number of failures/errors like old version used to do, ie: FAILURES!!! Tests run: 14, Failures: 0, Errors: 4 http://android.git.kernel.org/?p=platform/sdk.git;a=blob;f=ddms/libs/ddmlib/src/com/android/ddmlib/testrunner/RemoteAndroidTestRunner.java;h=d680509ff0dc028e60f12cb9726f7dbb53b19965;hb=HEAD#l226 simpligility@ecccb4a#L0L117
hugojosefson
added a commit
that referenced
this pull request
Jul 7, 2011
…-integration-tests Fix so that builds won't pass when integration tests fail
|
Great feedback. :) Thanks! |
|
Too funny. I never tested with failing tests so I did not notice ;-) |
|
You gotta have failing tests, otherwise what would you fix? :-) |
|
I know I just used it on already working projects and not in development.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the new 3.0.0-alpha-1 build, where failing integration tests don't stop the build from succeeding. The old, correct behaviour (as of 2.9.0-beta-5) was that a failing integration test would cause the build to fail :)
3.0.0-alpha-1 uses ddmlib instead of the adb command for instrumentation, but the
com.android.ddmlib.testrunner.RemoteAndroidTestRunner.run()method doesn't throw an exception when tests fail - instead it relies on the test listeners to report failures/errors to the user - so I've updated the AndroidTestRunListener to do just that, throwing aMojoFailureExceptionand also reporting the number of failures/errors like old version used to do, ie:FAILURES!!!
Tests run: 14, Failures: 0, Errors: 4