Issue 85

[cescoffier]

Instead of using the 'apkbuilder' executable (deprecated), I use the ApkBuilder class from sdklib.jar (which is the intended way). However as the jar is not available from Maven easily, I use dynamic loading and reflection.

Please review this patch as it is kind of tricky. I've made some tests with projects using resources, native librairies...

[hugojosefson]

Wow! Cool stuff.

Do you know what revision of the Android SDK we must require the user to have installed for this to work?

[cescoffier]

I'm using the Android SDK Tools, revision 7.
We probably should improve the fix to support the current version if the ApkBuilder cannot be initialized correctly.

[hugojosefson]

I suppose a fall-back to using the current command-line command apkbuilder should work. Then if they have an older SDK revision with which we can't initialize the ApkBuilder class, it should be old enough to let us use the command-line variant... :)

What do you think?

[cescoffier]

Yes, it's the way to go.
For safety, we can move the Method lookups into the initialize method. Then, we know if all reflective calls can be done.

[hugojosefson]

Good thinking. Would you do that please?

[cescoffier]

Yes, I will. I will pull the new versions this week.

[cescoffier]

Ok, finally it was quicker than expected. But, I don't know how to add a commit to this request, so I opened a new one:
http://github.com/jayway/maven-android-plugin/pull/7

[hugojosefson]

Cool. Actually, it seems they add it automatically. Check it out: http://github.com/jayway/maven-android-plugin/pull/6

Based on what I just saw, I think it works like this: The pull request you made (number 6), was for pulling from cescoffier:Issue-85, and when you push more commits there, the pull request page is automatically updated. I know from before that they automatically detect when to close a pull request based solely on what commits have been merged and pushed via standard git. I really like this with github :)

[cescoffier]

Oh, OK, that's why I didn't find the button ... it's automatic :-).

[cescoffier]

Just throw an RTE when the URL for the sdklib file cannot be computed. So, I think we're done.
WDYT ?

[hugojosefson]

Looks good.

I'll want to look at all of this more when I get back from DroidCon UK, and bring it in to master.

Thanks!

[amir20]

I have been following this issue. Thanks to git I am able to see everything! I appreciate your help. This is a great plugin for maven.