Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log display template doesn't remove all unused headers #114

Closed
wjtje opened this issue Aug 2, 2023 · 3 comments
Closed

Log display template doesn't remove all unused headers #114

wjtje opened this issue Aug 2, 2023 · 3 comments

Comments

@wjtje
Copy link

wjtje commented Aug 2, 2023

When using the following template with one commit fix: some weird bug

## Bugs
{{fix}}
## Feature
{{feat}}
## Improve
{{refactor,perf,clean}}
## Misc 
{{chore,style,ci||馃敹 Nothing change}}
## Unknown
{{__unknown__}}

The following changelog is generated:

## Bugs
- fix: some weird bug 1234567 @username
## Improve
{{refactor,perf,clean}}
## Misc 
馃敹 Nothing change

Instead of:

## Bugs
- fix: some weird bug 1234567 @username
## Misc 
馃敹 Nothing change

It seems like the RegEx on this line is not correct.
jaywcjlove added a commit that referenced this issue Aug 3, 2023
@jaywcjlove
fix: fix template format issue. (#114)
26812b1
jaywcjlove added a commit that referenced this issue Aug 3, 2023
@jaywcjlove
released v1.9.4 (#114)
0f55e0b
@jaywcjlove
Copy link
Owner

@wjtje Upgrade v1.9.4

@wjtje
Copy link
Author

wjtje commented Aug 3, 2023

The regex in the source code is now working, but I think that you forgot to compile it. Because the dist/index.js file still contains the old source code.

jaywcjlove added a commit that referenced this issue Aug 4, 2023
@jaywcjlove
fix: build js. (#114)
a3400d2
jaywcjlove added a commit that referenced this issue Aug 4, 2023
@jaywcjlove
released v1.9.5 (#114)
3290b9d
@jaywcjlove
Copy link
Owner

@wjtje has been recompiled. Upgrade v1.9.5

@wjtje wjtje closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaywcjlove @wjtje