Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unicode autoincrement #206

Merged
merged 1 commit into from Jun 10, 2023
Merged

Conversation

chenyulun
Copy link
Contributor

修复_startUnicode为空的场景unicode不自增的问题

@chenyulun
Copy link
Contributor Author

chenyulun commented Jun 9, 2023

场景一: 没有getIconUnicode配置或者配置执行无返回, curUnicode === _curUnicode && !_startUnicodetrue,自增
场景二:返回不一样的_curUnicode和一样的_startCode, curUnicode === _curUnicodefalse, 不自增,下一次接着使用老的startCode
场景三:返回了不一样的unicode和不返回_startCode, curUnicode === _curUnicodefalse, 不自增,下一次接着使用老的startCode
场景四 : 返回了一样的unicode和不一样的startCode,curUnicode === _curUnicode && startUnicode === _startUnicodefasle,不自增,被重新设置覆盖
场景五 : 返回不一样的unicode和不一样的startCode,curUnicode === _curUnicodefasle,不自增,被重新设置覆盖,不管是否和之前相同

@chenyulun chenyulun closed this Jun 9, 2023
@chenyulun chenyulun reopened this Jun 9, 2023
@wintercounter
Copy link

I believe this PR would solve our problem also. After upgrading to the latest, all icons are the same in the generated font files.

@chenyulun
Copy link
Contributor Author

chenyulun commented Jun 9, 2023

My fault, you can use the lower version(3.25.1) first, and it should be fixed later.

@jaywcjlove jaywcjlove merged commit 54bc335 into jaywcjlove:master Jun 10, 2023
github-actions bot pushed a commit that referenced this pull request Jun 10, 2023
Co-authored-by: chenyulun390 <chenyulun390@pingan.com.cn> 54bc335
@jaywcjlove
Copy link
Owner

Upgrade v3.25.4 @wintercounter @chenyulun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants