Fixes to Diaspora protocol handling #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jaywink
commented
Sep 4, 2016
jaywink
commented
- Don't quote/encode Protocol.build_send payload. It was doing it wrongly in the first place and also it's not necessary since Diaspora 0.6.
- Fix identification of Diaspora protocol messages. This was not working in the case that the attributes in the tag were in different order.
Current coverage is 91.41% (diff: 100%)@@ master #41 diff @@
==========================================
Files 13 13
Lines 700 699 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 639 639
+ Misses 61 60 -1
Partials 0 0
|
Socialhome was generating correct XML but attributes in different order than it seems other implementations.
jaywink
force-pushed
the
drop-urlencoding
branch
from
4ef1bb2
to
71ff2e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.