Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Diaspora protocol handling #41

merged 3 commits into from Sep 4, 2016


None yet
2 participants
Copy link

commented Sep 4, 2016

  • Don't quote/encode Protocol.build_send payload. It was doing it wrongly in the first place and also it's not necessary since Diaspora 0.6.
  • Fix identification of Diaspora protocol messages. This was not working in the case that the attributes in the tag were in different order.

@jaywink jaywink added the in progress label Sep 4, 2016


This comment has been minimized.

Copy link

commented Sep 4, 2016

Current coverage is 91.41% (diff: 100%)

Merging #41 into master will increase coverage by 0.13%

@@             master        #41   diff @@
  Files            13         13          
  Lines           700        699     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
  Hits            639        639          
+ Misses           61         60     -1   
  Partials          0          0          

Powered by Codecov. Last update 163e93b...71ff2e7

jaywink added some commits Sep 4, 2016

Fix identification of Diaspora protocol message
Socialhome was generating correct XML but attributes in different order than it seems other implementations.

@jaywink jaywink force-pushed the drop-urlencoding branch from 4ef1bb2 to 71ff2e7 Sep 4, 2016

@jaywink jaywink merged commit 5e5ed49 into master Sep 4, 2016

4 checks passed

code-quality/landscape Code quality increased by 0.01%
codecov/project 91.41% (+0.13%) compared to 163e93b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@jaywink jaywink deleted the drop-urlencoding branch Sep 4, 2016

@jaywink jaywink removed the in progress label Sep 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.