New nodes table #74
New nodes table #74
Conversation
src/views/_nodes_table.njk
Outdated
| {% set podname = pod.name %} | ||
| {% endif %} | ||
| <tr> | ||
| {% if pod.network == "unknown" %} |
There was a problem hiding this comment.
Actually this could be if pod.network not in ["diaspora", "friendica", "hubzilla", "redmatrix"] since those are the only images we have :) Not important, it used to be like this, but if you feel like changing it, would cause a few less 404 fetches.
There was a problem hiding this comment.
This code is copy pasted from the old page, I didn't even look at it. Don't hesitate if you have other feedback, I should also review / refactor it I guess. Maybe not in this PR ;)
src/views/network-page.njk
Outdated
| @@ -95,5 +95,13 @@ | |||
| </div> | |||
| </section> | |||
| {% include "charts/_stats_with_selectors.njk" %} | |||
| <section class="tile"> | |||
| <header> | |||
| <h2>All the {{texts.title}} nodes</h2> | |||
There was a problem hiding this comment.
Strictly speaking the is unnecessary here. All diaspora* nodes for example is better than All the diaspora* nodes, as an English speaker.
What do you mean no more pod chart? You mean the count of pods over time? Would defo like to keep that..
Do you mean the header doesn't stick to the top while scrolling? That was quite neat, it was actually contributed by someone else than me, to make the long list of pods actually readable. Would it be impossible to make it stick to the top while scrolling? For the previous table it was a ready plugin. |
Flaburgan
force-pushed
the
new-nodes-table
branch
from
c464037
to
fdc5242
Compare
I mean the global page is not able to display chart for a specific node anymore. This is going to be in the node page I'm building right now ;)
Yep. The feature is not here anymore with that PR because I removed external vendors. I can re-add it of course. Do you want it to be part of this PR, or can I do it in a following one? |
You can do as a follow-up - would be nice to have that as it makes the table is less usable otherwise. Thanks, mergy! |
|
:D we're getting somewhere! We'll bel feature complete soon :) |
This PR modifies a little bit the
allForListdatabase method used by an API. The result should be the same so we need to check after this is merged indev.that the return of the API is the same and we don't have any regression.This PR also fixes the version ordering method (actually, the order returns
0.5.1.0<0.5.10.2<0.5.2.0) and the software ordering method (described in https://github.com/jaywink/the-federation.info/issues/26)The header of the table is not actually collapsed when the page scrolls. Is that something we want?