UI UX changes #16
Merged
UI UX changes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k with the exception of the navbar, gave text shadow, changed background color and blended with background image, changed color scheme based on colors in notes above in css/style.css. Added footer with social icons and font-awesome cdn in index.html.
… positioning in css/style.css. Added pull-right to play and stop buttons in app.js. Removed bootstrap colons in labels and replaced with btn-lg in js/templates/intro.handlebars and js/templates/quiz.handlebars. Moved lyricsdiv and playbutton in js/templates/quiz.handlebars. Added trim for track name and artist in server.js.
This was referenced Nov 9, 2016
Closed
…x going past 5 question issue in js/app.js. Commented out width of new-game class to fix button centering in style.css.
…ment to check lyrics_body and throw an error. Allowing app.js to request a different song.
This was referenced Nov 10, 2016
|
Closing this pull request as I am adding to many bug fixes that could go into separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.