New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests #51

Merged

jayzes merged 1 commit into jayzes:master from glaszig:fix-tests

Apr 19, 2018

Collaborator

glaszig commented Apr 19, 2018

use Base64.strict_encode64 which does not add line feeds every few characters.

see https://ruby-doc.org/stdlib-2.2.0/libdoc/base64/rdoc/Base64.html#method-i-strict_encode64

::strict_encode64 also uses the same #pack logic
as rack-test does inside its #basic_authorize method.

see https://github.com/rack-test/rack-test/blob/72fc72dc15bfd33f45bc13cd134fb5e2c04dbe1e/lib/rack/test.rb#L166

more: https://glaucocustodio.github.io/2014/09/27/a-reminder-about-base64encode64-in-ruby/


          use Base64.strict_encode64 which does not

da0c270

add line feeds every few characters.

see https://ruby-doc.org/stdlib-2.2.0/libdoc/base64/rdoc/Base64.html#method-i-strict_encode64

::strict_encode64 also uses the same #pack logic
as rack-test does inside its #basic_authorize method.

see https://github.com/rack-test/rack-test/blob/72fc72dc15bfd33f45bc13cd134fb5e2c04dbe1e/lib/rack/test.rb#L166

more: https://glaucocustodio.github.io/2014/09/27/a-reminder-about-base64encode64-in-ruby/

glaszig mentioned this pull request

test against ruby 2.5 and ruby-head as well #52

Merged

Owner

jayzes commented Apr 19, 2018

Thanks!

jayzes merged commit 82cba14 into jayzes:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment