Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Justcfx2u promise fix #24

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Justcfx2u promise fix #24

merged 2 commits into from
Oct 17, 2019

Conversation

justcfx2u
Copy link
Contributor

Not well tested but it seems to be the "real" fix for #22

@justcfx2u
Update JZZ.js
0a103ec 
This patch avoids the following exception.
TypeError: Failed to execute 'requestMIDIAccess' on 'Navigator': Illegal invocation

This seems to occur when attempting to use JZZ from a ReactJS component.
Addresses #22
@justcfx2u
Update JZZ.js
d4aa04e 
Better fix for #22
@justcfx2u justcfx2u mentioned this pull request Oct 17, 2019
Closed
@jazz-soft jazz-soft merged commit fddbec0 into jazz-soft:master Oct 17, 2019
@jazz-soft
Copy link
Owner

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justcfx2u @jazz-soft