Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullcontext and AbstractContextManager #21

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Sep 9, 2019

Closes #16

Copy link
Collaborator

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've merged this as is, as it's a nice improvement already. However, there are a few items that would be needed to make it fully complete:

  • backport test cases for nullcontext
  • documentation updates
  • NEWS entry

@ncoghlan ncoghlan merged commit 739bd25 into jazzband:master Sep 20, 2019
jayvdb added a commit to jayvdb/contextlib2 that referenced this pull request Sep 21, 2019
@atugushev
Copy link
Member

atugushev commented Sep 21, 2019

@jayvdb thanks for backporting this! Perhaps it's time to use contextlib2 in pip-tools and remove this module.

atugushev added a commit to atugushev/pip-tools that referenced this pull request Sep 22, 2019
Context mamnager `nullcontext` has been added in contextlib2==0.6.0.
See jazzband/contextlib2#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebase API for Python 3.7
3 participants