Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik module should be renamed to Matomo #132

Closed
bittner opened this issue Aug 20, 2018 · 2 comments
Closed

Piwik module should be renamed to Matomo #132

bittner opened this issue Aug 20, 2018 · 2 comments
Labels
enhancement help-wanted

Comments

@bittner
Copy link
Member

bittner commented Aug 20, 2018

As commented in PR #128, Piwik has been renamed to Matomo in the past. This should also reflect in the name of the related module.

Ideally, we should use a deprecation path, duplicating the modules while the deprecation warning is active.
@sckarlin
Copy link
Contributor

sckarlin commented Apr 6, 2019

OK if I take a stab at this?

@jcassee
Copy link
Collaborator

jcassee commented Apr 6, 2019

@sckarlin Absolutely!

sckarlin added a commit to sckarlin/django-analytical that referenced this issue Apr 6, 2019
@sckarlin
Create Matomo module; leave Piwik to be deprecated
93b3cc3 
With the rebranding of Piwik to Matomo, this commit:
* copies the piwik module to matomo and rebrands
* notes that the piwik module is deprecated
* updates the javascript to the current Matomo version

Implements jazzband#132
@sckarlin sckarlin mentioned this issue Apr 6, 2019
Merged
sckarlin added a commit to sckarlin/django-analytical that referenced this issue Apr 8, 2019
@sckarlin
Create Matomo module; leave Piwik to be deprecated
694e712 
With the rebranding of Piwik to Matomo, this commit:
* copies the piwik module to matomo and rebrands
* notes that the piwik module is deprecated
* updates the javascript to the current Matomo version

Implements jazzband#132
sckarlin added a commit to sckarlin/django-analytical that referenced this issue Apr 9, 2019
@sckarlin
Create Matomo module; leave Piwik to be deprecated
8ed17e7 
With the rebranding of Piwik to Matomo, this commit:
* copies the piwik module to matomo and rebrands
* notes that the piwik module is deprecated
* updates the javascript to the current Matomo version

Implements jazzband#132
bittner pushed a commit that referenced this issue Apr 10, 2019
@sckarlin @bittner
Create Matomo module; leave Piwik to be deprecated
e5f8c19 
With the rebranding of Piwik to Matomo, this commit:
* copies the piwik module to matomo and rebrands
* notes that the piwik module is deprecated
* updates the javascript to the current Matomo version

Implements #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcassee @bittner @sckarlin