Add support for Google gtag.js #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase your branch so it could be merged? |
|
PR #140 is now merged. So, I think, this PR is obsolete? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dev team,
I had a go at doing the new google analytics 'gtag.js' library for tracking.
Sorry - I also just saw there was already a pull 140 for this -- though not sure if it went out-of-date?
I had only read isue 109, requesting the support (and had wanted to try using it myself/having a go coding it).
Perhaps the main difference in this code is that you can set context variables to go into the tracking snippet.
(i.e. can use gtag's "set" and "config" commands)
Though I also called the code 'google_gtag_js' rather than 'google_analytics_gtag'.
I have just been using my implementation, and I think it seems to work.
It's also got some tests and some documentation.
So I guess the code is free to be pulled into your project, anyway, if you would like too?
Cheers,
Peter