Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lucky Orange integration #175

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Conversation

bittner
Copy link
Member

@bittner bittner commented Dec 5, 2020

Adds a new integration for a service similar to Hotjar.

Fixes #172

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #175 (05213ae) into master (7f1358d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   94.14%   94.25%   +0.11%     
==========================================
  Files          28       29       +1     
  Lines        1246     1270      +24     
==========================================
+ Hits         1173     1197      +24     
  Misses         73       73              
Impacted Files Coverage Δ
analytical/templatetags/analytical.py 97.56% <ø> (ø)
analytical/templatetags/luckyorange.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1358d...05213ae. Read the comment docs.

@bittner bittner requested a review from smithdc1 December 5, 2020 20:14
@bittner bittner force-pushed the feature/luckyorange-integration branch 2 times, most recently from fb5ee72 to 9861063 Compare December 6, 2020 12:43
@bittner bittner mentioned this pull request Dec 6, 2020
@smithdc1
Copy link
Contributor

smithdc1 commented Dec 6, 2020

I proof read the docs and they seem good to me.

@bittner bittner force-pushed the feature/luckyorange-integration branch from 9861063 to 05213ae Compare December 6, 2020 15:45
@bittner
Copy link
Member Author

bittner commented Dec 6, 2020

Okay, I rebased the branch. So, we only need to decide whether we want to require explicit confirmation from Lucky Orange support on the included CDN URL, before merging.

BTW, to implement this integration I simply copy+pasted & search+replaced the excellent Hotjar integration code, including the docs. And for the rebasing I made sure with a diff that everything is still super-aligned. So, I'm standing on the shoulders of others who are bigger, smarter and more hardworking than I am. – Thanks @PiDelport!

@bittner bittner merged commit 8cd75d9 into master Dec 6, 2020
@bittner bittner deleted the feature/luckyorange-integration branch December 6, 2020 19:45
@bittner bittner removed the request for review from jcassee December 6, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lucky Orange integration
3 participants