Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 and drop Django 3.1 #198

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Conversation

smithdc1
Copy link
Contributor

@smithdc1 smithdc1 commented Oct 6, 2021

Hey, hope all is well.

This PR adds Python 3.10 supprt and also drops support from Django 3.1 which is now EOL.

Following review and merge of this do you think we could issue a new release to confirm support of these new versions?

@smithdc1 smithdc1 requested a review from bittner October 6, 2021 05:56
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #198 (8e54c4e) into master (1923108) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          31       31           
  Lines        1363     1363           
=======================================
  Hits         1288     1288           
  Misses         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1923108...8e54c4e. Read the comment docs.

@bittner
Copy link
Member

bittner commented Oct 24, 2021

Ooops, I'm sorry, looks like I overlooked this PR when you opened it more than 2 weeks ago! 😟

I'm working on rebasing #174 at this very moment. I might include your changes there, too. I hope that's fine for you.

And yes, I'm okay with issuing a new release afterwards, sure!

@bittner
Copy link
Member

bittner commented Oct 24, 2021

Python 3.10 is not supported by any Django version yet. See the meta data of, e.g., Django 4.0 alpha 1 on PyPI for reference.

Django 3.1 is still supported until the end of this year, according to the Django Project website.

Can we wait with your changes until January next year?

@smithdc1
Copy link
Contributor Author

Ah yes. I got carried away a couple of weeks ago.

4.0b1 has been released today and supports 3.10. the next point release of 3.2. will be released next week (1st of each month right?) which will add 3.10 support.

https://pypi.org/project/Django/4.0b1/

Happy for you to roll it into your other PR.

@smithdc1
Copy link
Contributor Author

smithdc1 commented Nov 2, 2021

A short update as time has moved on. 3.2.9 and 4.0b1 are both released and support Python 3.10
https://pypi.org/project/Django/3.2.9/
https://pypi.org/project/Django/4.0b1/

@bittner bittner mentioned this pull request Nov 26, 2021
@bittner bittner merged commit aa29a05 into jazzband:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants