-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI setup #227
base: main
Are you sure you want to change the base?
Update CI setup #227
Conversation
jezdez
commented
May 2, 2023
- remove support for Django 2.2
- remove support for Django 4.0
- add support for Django 4.2
- add support for Python 3.11 on supported Django versions
- remove support for Django 2.2 - remove support for Django 4.0 - add support for Django 4.2 - add support for Python 3.11 on supported Django versions
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 31 31
Lines 1344 1344
=======================================
Hits 1270 1270
Misses 74 74 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
${{ matrix.python-version }}-v1-${{ hashFiles('**/setup.py') }} | ||
restore-keys: | | ||
${{ matrix.python-version }}-v1- | ||
cache: 'pip' # caching pip dependencies | ||
|
||
- name: Install dependencies | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also skip the Pip version check, relying on GitHub to ship a fairly recent, continuously updated version. E.g.
python -m pip install tox-gh-actions wheel --disable-pip-version-check
Co-authored-by: Peter Bittner <django@bittner.it>
django-version: | ||
- '2.2' | ||
- '3.2' | ||
- '4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the version numbers here, too!
- { django-version: '4.0', python-version: '3.7' } | ||
- { django-version: '4.1', python-version: '3.7' } | ||
- { django-version: '4.2', python-version: '3.7' } | ||
- { django-version: '3.2', python-version: '3.11' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to exclude Python 3.6 for Django 4.1 and 4.2, too!
In addition, Django 3.2 doesn't officially support Python 3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to be finished and merged.
python-django: | ||
runs-on: ubuntu-latest | ||
test: | ||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: ubuntu-20.04 | |
runs-on: ubuntu-latest |
We should simply drop Python 3.6 support. GitHub's VMs for GHA have stopped shipping unsupported Python versions. That makes things difficult.