Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation ID - Part 1 #481

Merged
merged 13 commits into from
Dec 23, 2022
Merged

Correlation ID - Part 1 #481

merged 13 commits into from
Dec 23, 2022

Conversation

aqeelat
Copy link
Member

@aqeelat aqeelat commented Dec 18, 2022

feat: Added support for storing correlation ids passed to a custom header

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #481 (5238a70) into master (a733cd0) will increase coverage by 0.41%.
The diff coverage is 98.50%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   92.83%   93.24%   +0.41%     
==========================================
  Files          27       29       +2     
  Lines         795      859      +64     
==========================================
+ Hits          738      801      +63     
- Misses         57       58       +1     
Impacted Files Coverage Δ
auditlog/filters.py 91.66% <90.90%> (-0.65%) ⬇️
auditlog/admin.py 100.00% <100.00%> (ø)
auditlog/cid.py 100.00% <100.00%> (ø)
auditlog/conf.py 100.00% <100.00%> (ø)
auditlog/middleware.py 100.00% <100.00%> (ø)
auditlog/migrations/0014_logentry_cid.py 100.00% <100.00%> (ø)
auditlog/mixins.py 89.28% <100.00%> (+1.40%) ⬆️
auditlog/models.py 87.96% <100.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani
Copy link
Member

@aqeelat Thanks for this. this is a good starting point 👍

Please remember to rebase the patch and re-run the makemigrations command (because I have merged #478)

I will take a look later this week

@aqeelat
Copy link
Member Author

aqeelat commented Dec 19, 2022

@hramezani updated.

auditlog/cid.py Outdated Show resolved Hide resolved
auditlog/cid.py Outdated Show resolved Hide resolved
auditlog_tests/tests.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @aqeelat for the update.
I left some comments.

Please add documentation for the new settings and also add tests for checking the saved cid in the model.

@aqeelat
Copy link
Member Author

aqeelat commented Dec 21, 2022

@hramezani done

auditlog/cid.py Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
docs/source/usage.rst Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @aqeelat for updating the patch.
I've left some comments. Please address them.

Please also add test to proved saved cid value in model

aqeelat and others added 3 commits December 21, 2022 11:06
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@aqeelat
Copy link
Member Author

aqeelat commented Dec 21, 2022

Thanks @aqeelat for updating the patch.

I've left some comments. Please address them.

Please also add test to proved saved cid value in model

I added the test already. It should be in the same middleware test. I compared the value in the history with the expected value.

@hramezani
Copy link
Member

I think everything is done. you just need to update the comment in cid.py. Then we are good to go

@aqeelat
Copy link
Member Author

aqeelat commented Dec 22, 2022

@hramezani all is done now. LMK if you need anything else.

@hramezani hramezani merged commit bc6d393 into jazzband:master Dec 23, 2022
@aqeelat aqeelat deleted the cid_get branch December 23, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants