Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repr of a json field in field changes #489

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

CleitonDeLima
Copy link
Contributor

@CleitonDeLima CleitonDeLima commented Dec 29, 2022

Resolve #476

My doubt is related to the sort_keys=True of the dumps, I believe it is worth keeping for comparison reasons.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #489 (75e7b02) into master (7f8edd5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   94.11%   94.13%   +0.01%     
==========================================
  Files          30       30              
  Lines         884      886       +2     
==========================================
+ Hits          832      834       +2     
  Misses         52       52              
Impacted Files Coverage Δ
auditlog/diff.py 97.29% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani
Copy link
Member

Thanks @CleitonDeLima 👍

Please add a changelog entry in Improvements section of https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

@hramezani hramezani merged commit ffa6d34 into jazzband:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes logged for JSON-field aren't valid JSON
2 participants