raise AuditLogRegistrationError on invalid app in settings #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 94.13% 94.15% +0.01%
==========================================
Files 30 30
Lines 886 889 +3
==========================================
+ Hits 834 837 +3
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hramezani
reviewed
Jan 3, 2023
hramezani
reviewed
Jan 3, 2023
|
Thanks @tykling for the fix. @alieh-rymasheuski Do you want to take a look? |
aleh-rymasheuski
approved these changes
Jan 3, 2023
tykling
deleted the
issue-491-return-better-error-message-when-invalid-app-in-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a test to trigger the issue. Fixes #491