Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment related things to .gitignore #1042

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

hirotasoshu
Copy link
Contributor

@hirotasoshu hirotasoshu commented Apr 25, 2023

Add all environments related things, copied from https://github.com/github/gitignore/blob/main/Python.gitignore
Resolves #1041

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1042 (9a24bee) into master (f491f3d) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   96.20%   95.92%   -0.29%     
==========================================
  Files          34       34              
  Lines        1055     1055              
  Branches      188      188              
==========================================
- Hits         1015     1012       -3     
- Misses         34       37       +3     
  Partials        6        6              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hirotasoshu hirotasoshu changed the title chore: add venv to .gitignore Add environment related things to .gitignore Apr 25, 2023
@hirotasoshu
Copy link
Contributor Author

@aleksihakli do you have any idea why this change decreased test coverage?

@aleksihakli aleksihakli merged commit 128b5c6 into jazzband:master Apr 26, 2023
20 checks passed
@aleksihakli
Copy link
Member

Probably the test automat is measuring funny things on Codecov, doesn't seem to be anything big at least :)

https://app.codecov.io/gh/jazzband/django-axes/pull/1042/indirect-changes

Thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add venv folder to .gitignore
2 participants