Add async support to middleware #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taikono-Himazin
force-pushed
the
master
branch
from
ab8503b
to
6f2584b
Compare
|
I've tested this in my async views and it works like a charm! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 94.35% 93.56% -0.80%
==========================================
Files 35 35
Lines 1151 1165 +14
Branches 211 215 +4
==========================================
+ Hits 1086 1090 +4
- Misses 49 57 +8
- Partials 16 18 +2 ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR @Taikono-Himazin This has been released as part of version 6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added middleware Async support.
I tried using it at hand, and it seems to have no problems. The existing pytest is also passing.
However, I wasn't sure how to add documentation and tests.
I would like to know if you know how to switch between Django's Async mode and Sync mode, and how to run pytest while switching between Async mode and Sync mode.
Related issue