Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require asgiref>=3.6.0 #1188

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Require asgiref>=3.6.0 #1188

merged 1 commit into from
Apr 15, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Apr 3, 2024

django-axes is making use of some functions added in asgiref==3.6.0, but Django 3.2 requires asgiref>=3.3.2.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

`django-axes` is making use of some functions added in
`asgiref==3.6.0`, but Django 3.2 requires `asgiref>=3.3.2`.
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (fd9d185) to head (61c6dd9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          35       35           
  Lines        1161     1161           
  Branches      215      215           
=======================================
  Hits         1089     1089           
  Misses         54       54           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleksihakli
Copy link
Member

Thank you @Viicos!

@aleksihakli aleksihakli merged commit 43b5017 into jazzband:master Apr 15, 2024
20 checks passed
@Viicos Viicos deleted the patch-1 branch April 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants