Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize newlines from form #397

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Normalize newlines from form #397

merged 3 commits into from
Jun 4, 2020

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented May 25, 2020

Close #396

utapyngo
utapyngo previously approved these changes May 26, 2020
View reviewed changes
@utapyngo utapyngo dismissed their stale review May 26, 2020 10:17

Please add a test for new code.

jezdez
jezdez requested changes May 26, 2020
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mogost, please add a test case for this.

@Mogost
Copy link
Member Author

Mogost commented May 26, 2020

Thanks @utapyngo for the tests

@utapyngo utapyngo requested a review from jezdez May 26, 2020 13:12
@Mogost
Copy link
Member Author

Mogost commented Jun 4, 2020

@camilonova @jezdez Could you take a look at that?

@Mogost Mogost merged commit 9e6dc03 into jazzband:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezdez jezdez jezdez approved these changes

@utapyngo utapyngo utapyngo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong "is modified" in admin for multi line strings
3 participants
@Mogost @jezdez @utapyngo