Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchors in admin #402

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add anchors in admin #402

merged 3 commits into from
Jun 9, 2020

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Jun 5, 2020

Very often there is a need to provide links to a specific setting, anchors would be very useful.
image

@Mogost Mogost requested review from jezdez and camilonova June 5, 2020 11:23
@jezdez
Copy link
Member

jezdez commented Jun 8, 2020

I really like the idea but visually this can be improved, maybe by just using the item name as the link text instead of adding the extra character.

@Mogost
Copy link
Member Author

Mogost commented Jun 8, 2020

@jezdez
I originally did so, but I didn’t like that the whole title behaves like a link. This is reflected in colors, etc. In general, ideally, we need to add some more css so that the symbol is shown exclusively when you hover over the inscription. An example of this behavior is in github.
image

@jezdez
Copy link
Member

jezdez commented Jun 8, 2020

Yeah, fair point, let's do the hover idea.

@Mogost
Copy link
Member Author

Mogost commented Jun 9, 2020

@jezdez done

@jezdez
Copy link
Member

jezdez commented Jun 9, 2020

Could you add a new screenshot please?

@jezdez
Copy link
Member

jezdez commented Jun 9, 2020

Or has this not changed visually other than the hover effect?

@Mogost
Copy link
Member Author

Mogost commented Jun 9, 2020

image
on hover
image
I tried this on my project, at first glance it works well and copes equally well with both long and short variable names.
In the worst case scenario, if I did not take something into account, this will not lead to critical consequences and we will be informed about this in issues.

@jezdez jezdez merged commit 788616d into jazzband:master Jun 9, 2020
@Mogost
Copy link
Member Author

Mogost commented Jun 9, 2020

@jezdez I have also been waiting for a new release for a very long time. I'm still using 2.4.0 in my project because #383 affected me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants