'six' package dependency removed #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
reviewed
Nov 11, 2020
Comment on lines
9
to
10
| from dbbackup.db.postgresql import (PgDumpBinaryConnector, PgDumpConnector, | ||
| PgDumpGisConnector) |
There was a problem hiding this comment.
Do you think you could keep the format as before as that is easier to read?
Suggested change
| from dbbackup.db.postgresql import (PgDumpBinaryConnector, PgDumpConnector, | |
| PgDumpGisConnector) | |
| from dbbackup.db.postgresql import ( | |
| PgDumpBinaryConnector, | |
| PgDumpConnector, | |
| PgDumpGisConnector | |
| ) |
jonathan-s
reviewed
Nov 11, 2020
dbbackup/utils.py
Outdated
Comment on lines
4
to
5
| from __future__ import (absolute_import, division, print_function, | ||
| unicode_literals) |
There was a problem hiding this comment.
Same here.
Suggested change
| from __future__ import (absolute_import, division, print_function, | |
| unicode_literals) | |
| from __future__ import ( | |
| absolute_import, | |
| division, | |
| print_function, | |
| unicode_literals | |
| ) |
jonathan-s
reviewed
Nov 11, 2020
dbbackup/tests/test_utils.py
Outdated
| callable_for_filename_template, | ||
| DEV_NULL, add_public_gpg) | ||
| clean_gpg_keys) |
There was a problem hiding this comment.
And change the formatting here as well.
|
Thanks a lot for making these changes! |
|
Thanks for the suggestion and will make the changes asap. BTW, I used the isort package to sort the imports. IMHO, we should add some kind of config file so that we can keep unified formatting rules across the repository/package. And later, the pipeline will take care of the checks |
|
I hope everything is fine now, isn't it? |
jonathan-s
approved these changes
Nov 12, 2020
|
Thanks a lot @jerinpetergeorge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
enhancement
Description
Removed six package dependency and cleaned the codebase.
Fixes #370
Checklist