Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql schema support #424

Closed
wants to merge 14 commits into from
Closed

Add postgresql schema support #424

wants to merge 14 commits into from

Conversation

twkrol
Copy link

@twkrol twkrol commented Jan 26, 2022

Type of PR (feature, enhancement, bug fix, etc.)

Feature

Description

Added '-n' for specyfing schema to backup/restore

Why should this be added

Usefull for multitenant applications where customer's data are separated by schema, so one can backup/restore selected schema only

Checklist

  • Documentation has to be added for this feature

@Archmonger
Copy link
Contributor

Since this appears to not be ready for review, I am marking this PR as draft.

Please mark it as "Not Draft" when lint/tests are passing

@Archmonger Archmonger marked this pull request as draft February 8, 2022 08:18
@eriktelepovsky
Copy link
Contributor

Great feature. Looking forward to it!

@Archmonger
Copy link
Contributor

@twkrol Are you still planning to work this PR?

@twkrol
Copy link
Author

twkrol commented Apr 29, 2022

Yeah, I want to. Just got some busy days recently.

@angryfoxx
Copy link
Contributor

Hi @twkrol @Archmonger, What is the status of this PR? Why is the status in the draft?

@twkrol
Copy link
Author

twkrol commented Dec 27, 2023

Hey, I would love to merge this feature, but need help to make tests. Anyone?

@Archmonger
Copy link
Contributor

@angryfoxx Tests are still needed for this PR.

On top of that, there's a more pressing issue that blocks all PRs from being merged #483

@angryfoxx
Copy link
Contributor

Hi again @Archmonger, is that issue still persisting? I can write test and update this pr if there is no blocker.

@Archmonger
Copy link
Contributor

Yes.

@johnthagen has created a workaround for our broken workflows. PRs are now mergeable again.

@johnthagen
Copy link
Contributor

@angryfoxx Please resolve merge conflicts and merge main in your branch for CI to run properly.

@angryfoxx
Copy link
Contributor

Hi again guys @Archmonger @johnthagen. I have created pr about that issue and could you review it ?
#507

@Archmonger
Copy link
Contributor

Closing this in favor of #507

@Archmonger Archmonger closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants