Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Django 4.2 Trove classifier #1745

Merged
merged 1 commit into from Apr 3, 2023
Merged

Conversation

carltongibson
Copy link
Member

@carltongibson
Copy link
Member Author

carltongibson commented Mar 4, 2023

Hmmm. Still not showing up according to tox/hatchling 🤔

@tim-schilling
Copy link
Contributor

This is dependent on pypa/hatch#762 being merged.

@matthiask
Copy link
Member

matthiask commented Mar 5, 2023

Thanks!

I've seen https://lincolnloop.com/insights/using-pyprojecttoml-in-your-django-project/ in the Django Newsletter and am wondering if the move to hatch wasn't premature after all. I've seen the other ticket and the reasoning behind it, and it makes sense to me. I also understand why setup.py is problematic. But the warm fuzzy feeling I had re. Python packaging in the last years (everything worked well for me) has yet to come back.

(I'm not advocating a move away from hatch, just sharing.)

@tim-schilling tim-schilling mentioned this pull request Mar 11, 2023
2 tasks
@tim-schilling
Copy link
Contributor

@matthiask I'm currently out on vacation. Can you merge this and the version release PRs?

@pauloxnet
Copy link
Member

@matthiask I'm currently out on vacation. Can you merge this and the version release PRs?

There are some jobs that failed, so I restarted the pipeline.

@matthiask matthiask merged commit e9e1968 into main Apr 3, 2023
20 checks passed
@matthiask
Copy link
Member

Thanks! Will do. The change is obviously correct, I'll fix the remaining problems on main (if the failures still occur)

@matthiask matthiask deleted the carltongibson-patch-1 branch April 3, 2023 14:37
@tim-schilling
Copy link
Contributor

Thank you @matthiask!

@matthiask
Copy link
Member

Thanks for all the preparation, I just had to press a few buttons :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants